-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgidBidAdapter: Add gpid value to bid request's imp[].ext #11916
Conversation
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
Hello, as to deduplicating issue, I can't address it right now, and I will schedule time for this in the next sprints as it is unexpected task for the scope I've committed. |
also, please explain how I should remedy the following, for both adapters are the same: modules/mgidBidAdapter.js has 7 duplicated lines with modules/mgidBidAdapter.js |
You do the same thing in each of those two cases. Define the constant you want outside of the switch and use it twice, or use an or inside your switch |
Thanks for your attention on this matter soon, merging |
Co-authored-by: gaudeamus <dmitry.markelov@mgid.com>
Co-authored-by: gaudeamus <dmitry.markelov@mgid.com>
Type of change
Description of change
Adding gpid value for each bid request impression. No api changes